Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with errors not throwing the error callback in windows. #235

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Fix problem with errors not throwing the error callback in windows. #235

merged 3 commits into from
Dec 11, 2018

Conversation

Eeems
Copy link
Contributor

@Eeems Eeems commented Dec 11, 2018

Had to create a new PR for #52 as I had deleted the fork where the original PR came from.
From the original PR:

On windows when attempting to open pdf files Windows.System.Launcher.launchFileAsync() is throwing the following error: "The parameter is incorrect"
This error is not running the callback error due to not being caught by the promise handler. Adding a try/catch will solve this and at least allow the error to bubble up to the users code and allow them to debug it easier.
Should at least help with #51 but not fix it.

@shnist
Copy link
Collaborator

shnist commented Dec 11, 2018

@Eeems thanks for doing this.

@Eeems Eeems deleted the Eeems-patch-1 branch December 23, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants