Fix problem with errors not throwing the error callback in windows. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @Eeems, thanks very much for your contribution to this project. I appreciate that you raised this PR over 3 years ago and no one responded to it. Apologies for that. If you're still interested in getting this PR merged let me know and we can work together to make it happen. |
|
@shnist I am no longer using cordova, but I can fix up the merge conflicts so that the PR is valid again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows when attempting to open pdf files Windows.System.Launcher.launchFileAsync() is throwing the following error: "The parameter is incorrect"
This error is not running the callback error due to not being caught by the promise handler. Adding a try/catch will solve this and at least allow the error to bubble up to the users code and allow them to debug it easier.
Should at least help with #51 but not fix it.