Skip to content

Commit

Permalink
fix for ubuntu 20.04 (#748)
Browse files Browse the repository at this point in the history
  • Loading branch information
@haxmeadroom
haxmeadroom committed May 4, 2020
1 parent 2a09b30 commit d3ec217
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions requirements.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ pygments
capstone==4.0.1
enum34
pytest
testresources
4 changes: 3 additions & 1 deletion setup.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ osx() {

install_apt() {
sudo apt-get update || true
sudo apt-get -y install gdb python-dev python3-dev python-pip python3-pip libglib2.0-dev libc6-dbg
# This breaks Ubuntu 20.04, but is probably still needed for older version
sudo apt-get -y python-pip || true
sudo apt-get -y install gdb python-dev python3-dev python3-pip libglib2.0-dev libc6-dbg

if uname -m | grep x86_64 > /dev/null; then
sudo apt-get -y install libc6-dbg:i386 || true
Expand Down

3 comments on commit d3ec217

@martinclauss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haxmeadroom could it be the case that the install is missing in sudo apt-get -y python-pip?

Best
Martin

@haxmeadroom
Copy link
Contributor Author

@haxmeadroom haxmeadroom commented on d3ec217 May 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are definitely right. Is it still needed for Ubuntu <20.04?

@haxmeadroom
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this in PR #763

Please sign in to comment.