Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for ubuntu 20.04 #748

Merged
merged 1 commit into from
May 4, 2020
Merged

fix for ubuntu 20.04 #748

merged 1 commit into from
May 4, 2020

Conversation

haxmeadroom
Copy link
Contributor

Fixes Issue with Ubuntu 20.04, which no longer has python-pip

zachriggle
zachriggle reviewed Apr 30, 2020
View reviewed changes
requirements.txt
@@ -12,3 +12,4 @@ pygments
capstone==4.0.1
enum34
pytest
testresources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's required, but it got rid of this message:
ERROR: launchpadlib 1.10.13 requires testresources, which is not installed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to move to install this only for ubuntu/debian installs via python3-testresources as in pypa/pip#5372

@disconnect3d
Copy link
Member

Tested this branch on ubuntu:18.04, ubuntu:19.10 and ubuntu:20.04 with this Dockerfile (only changing the image):

FROM ubuntu:20.04

ARG DEBIAN_FRONTEND=noninteractive

RUN apt update && apt install -y git gdb && \
	git clone https://github.com/haxmeadroom/pwndbg.git && \
	cd pwndbg && git checkout dev && \
	 ./setup.sh

Seems to install & work fine (docker build -t pwn . && docker run --rm -it --cap-add=SYS_PTRACE pwn gdb /bin/ls). Thanks!

@disconnect3d disconnect3d merged commit d3ec217 into pwndbg:dev May 4, 2020
@haxmeadroom haxmeadroom mentioned this pull request May 26, 2020
Merged
disconnect3d pushed a commit that referenced this pull request May 29, 2020
@haxmeadroom
Changes in dependencies needed for Ubuntu, starting from scratch. (#763)
677dfa2 
* Added install to apt line: fixed bug mentioned by @martinclauss in #748 that might be needed for Ubuntu <20.04.
* Added git to apt-get, which is needed for a docker run -it ubuntu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachriggle zachriggle zachriggle left review comments

@disconnect3d disconnect3d disconnect3d left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haxmeadroom @disconnect3d @zachriggle