Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1165: set context-clear-screen on resetting scrollback #1166

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

disconnect3d
Copy link
Member

This commit tries to fix the issue of our set context-clear-screen on option resetting the scrollback buffer on some terminals like gnome-terminal (fwiw it did not happen on terminator or on tmux).

It also adds info to tips about that option.

More details in #1165

This commit tries to fix the issue of our `set context-clear-screen on`
option resetting the scrollback buffer on some terminals like
gnome-terminal (fwiw it did not happen on terminator or on tmux).

It also adds info to tips about that option.
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Merging #1166 (2364af2) into dev (30cd4c7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #1166   +/-   ##
=======================================
  Coverage   52.68%   52.68%           
=======================================
  Files         178      178           
  Lines       20044    20044           
  Branches     1837     1837           
=======================================
  Hits        10561    10561           
  Misses       9075     9075           
  Partials      408      408           
Impacted Files Coverage Δ
pwndbg/commands/context.py 55.60% <0.00%> (ø)
pwndbg/lib/tips.py 80.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@disconnect3d disconnect3d merged commit 3b2f779 into dev Sep 25, 2022
@disconnect3d disconnect3d deleted the fix-clear-screen branch September 25, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants