events.py: remove unused Pause class #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsingh93
reviewed
Oct 5, 2022
pwndbg/gdblib/events.py
Outdated
| @@ -12,8 +12,7 @@ | |||
|
|
|||
| import pwndbg.config | |||
|
|
|||
| debug = pwndbg.config.Parameter("debug-events", False, "display internal event debugging info") | |||
| pause = 0 | |||
| debug = pwndbg.config.Parameter("debug-events", True, "display internal event debugging info") | |||
There was a problem hiding this comment.
You probably don't want to make the default True?
There was a problem hiding this comment.
No, good catch; that was from other testing
disconnect3d
commented
Oct 5, 2022
|
This seems to be used in |
|
@gsingh93 how? there is an |
disconnect3d
force-pushed
the
remove-unused-Pause-code
branch
from
a111a56
to
447a63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.