-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDB Refactor [21/N]: Move symbol.py to gdblib #1259
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1259 +/- ##
==========================================
- Coverage 54.52% 54.45% -0.07%
==========================================
Files 182 182
Lines 20217 20214 -3
Branches 1865 1865
==========================================
- Hits 11023 11008 -15
- Misses 8761 8783 +22
+ Partials 433 423 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@CptGibbon @lebr0nli this PR is surfacing any exceptions that were previously caught when doing symbol lookup, and only ignoring a small set of them. On Ubuntu 18.04 and 20.04 (but not 22.04), I see the following exception in Do either of you know why that's happening? What's changed in |
Looks like the test binary needs to be linked against libpthread, I can submit a PR |
c809f54
to
81938d1
Compare
81938d1
to
d9313ce
Compare
# lookup a symbol. We want to raise these errors so we can handle them | ||
# properly, but there are some we haven't figured out how to fix yet, so | ||
# we ignore those here | ||
skipped_exceptions = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
skipped_exceptions = (
# comment here
"No frame selected",
...
)
but this can be changed in a next PR as well
A couple of changes to symbol.py other than the move:
pwndbg.symbol.address
pwndbg.symbol.address
. I didn't see any usages of this in the codebase, and allowing so many arbitrary formats will lead to bugsgdb.lookup_symbol
are no longer ignored, except for the one case of "No frame selected" errors. This is only occurring in the Go typeinfo tests, and I think the exception probably makes sense, but I want to dig into it a bit more and confirm the right fix is to usegdb.selected_frame()
first.info address