Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1259 I removed the code using
info address
to resolve symbols, asgdb.lookup_symbol
should have covered this. However, there seems to be some issue withgdb.lookup_symbol
: https://sourceware.org/pipermail/gdb/2022-October/050362.htmlThe main place this broke things was in heap heuristics. Since this was missed by the tests, new tests were added in #1283, and this PR is based on top of that one.
This PR adds back in the
info address
lookup, with a comment explaining why we need it.