Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol resolution issue #1287

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix symbol resolution issue #1287

merged 1 commit into from
Oct 14, 2022

Conversation

gsingh93
Copy link
Member

In #1259 I removed the code using info address to resolve symbols, as gdb.lookup_symbol should have covered this. However, there seems to be some issue with gdb.lookup_symbol: https://sourceware.org/pipermail/gdb/2022-October/050362.html

The main place this broke things was in heap heuristics. Since this was missed by the tests, new tests were added in #1283, and this PR is based on top of that one.

This PR adds back in the info address lookup, with a comment explaining why we need it.

@codecov-commenter
Copy link

Codecov Report

Merging #1287 (8963365) into dev (e456b31) will increase coverage by 0.97%.
The diff coverage is 85.63%.

@@            Coverage Diff             @@
##              dev    #1287      +/-   ##
==========================================
+ Coverage   55.52%   56.50%   +0.97%     
==========================================
  Files         187      187              
  Lines       20409    20559     +150     
  Branches     1887     1907      +20     
==========================================
+ Hits        11333    11617     +284     
+ Misses       8651     8472     -179     
- Partials      425      470      +45     
Impacted Files Coverage Δ
pwndbg/heap/ptmalloc.py 53.81% <44.82%> (+10.22%) ⬆️
pwndbg/glibc.py 75.43% <50.00%> (+12.93%) ⬆️
pwndbg/gdblib/symbol.py 45.35% <75.00%> (+1.39%) ⬆️
tests/heap/test_heap.py 96.51% <95.45%> (-3.49%) ⬇️
pwndbg/gdblib/info.py 68.42% <100.00%> (+15.08%) ⬆️
pwndbg/disasm/__init__.py 59.58% <0.00%> (+0.68%) ⬆️
pwndbg/gdblib/memory.py 67.79% <0.00%> (+0.84%) ⬆️
pwndbg/gdblib/regs.py 71.24% <0.00%> (+1.30%) ⬆️
pwndbg/heap/structs.py 80.00% <0.00%> (+1.42%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsingh93 gsingh93 merged commit e5e73fa into pwndbg:dev Oct 14, 2022
@gsingh93 gsingh93 deleted the fix-symbol branch October 14, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants