Fix setting empty ctx sections #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `validate_context_sections` function started to receive a string of `"''"` after the changes in eabab31. Before those changes, it always received an empty string (`""`). I am not sure why this behavior changed in that commit, but the current behavior resembles the native GDB behavior more. We can see this here on a GDB native parameter: ``` (gdb) set exec-wrapper '' (gdb) show exec-wrapper The wrapper for running programs is "''". ``` And so we will keep this native behavior for our config variables for now. But since this changed, I want to keep the old behavior of: `set context-sections ''` working, and so this commit brings it. Additionally, we also now allow setting empty context via multiple values: empty string, empty quotations or double quotations and with strings like `-` or `none`. ...and this commit comes with tests for this behavior so it will be harder to introduce such issues anymore :)
Codecov Report
@@ Coverage Diff @@
## dev #1310 +/- ##
==========================================
+ Coverage 54.58% 54.59% +0.01%
==========================================
Files 156 156
Lines 19394 19394
Branches 1806 1806
==========================================
+ Hits 10586 10589 +3
Misses 8365 8365
+ Partials 443 440 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.