Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint CI job and Ubuntu 22.04 and 18.04 #1505

Merged
merged 2 commits into from Jan 5, 2023
Merged

Conversation

gsingh93
Copy link
Member

@gsingh93 gsingh93 commented Jan 5, 2023

The current linter is using Python 3.8, instead let's use the oldest and newest platforms we support. We're currently missing linter issues because things that are passing on CI on 3.8 are not passing on 3.10, so we need to check both.

@gsingh93
Copy link
Member Author

gsingh93 commented Jan 5, 2023

This confirms lint is passing on Ubuntu 18.04 but failing on Ubuntu 22.04. #1502 is the PR that broke it.

@gsingh93 gsingh93 merged commit d9f6934 into pwndbg:dev Jan 5, 2023
@gsingh93 gsingh93 deleted the lint branch January 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant