Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint CI job and Ubuntu 22.04 and 18.04 #1505

Merged
merged 2 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ on: [push, pull_request]

jobs:
lint:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
# Only care about the oldest and newest versions
os: [ubuntu-22.04, ubuntu-18.04]
runs-on: ${{ matrix.os }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
Expand All @@ -13,11 +18,6 @@ jobs:
path: ~/.cache/pip
key: ${{ matrix.os }}-cache-pip

- name: Set up Python 3.8
uses: actions/setup-python@v4
with:
python-version: 3.8

- name: Install dependencies
run: |
./setup.sh --user
Expand Down
2 changes: 1 addition & 1 deletion pwndbg/heap/ptmalloc.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from typing import Any
from typing import Dict
from typing import Set
from typing import Union
from typing import Union # noqa: F401

import gdb

Expand Down
2 changes: 1 addition & 1 deletion pwndbg/lib/memoize.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from typing import Any
from typing import Callable
from typing import Dict
from typing import List
from typing import List # noqa: F401

debug = False

Expand Down