-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a few new memory APIs and replace old APIs #2155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2155 +/- ##
========================================
- Coverage 3.65% 3.64% -0.01%
========================================
Files 196 196
Lines 25383 25640 +257
Branches 2597 2622 +25
========================================
+ Hits 928 935 +7
- Misses 24327 24572 +245
- Partials 128 133 +5 ☔ View full report in Codecov by Sentry. |
4062a5f
to
729df0e
Compare
With noting that there is a risk that people who have scripts that use pwndbg's gdblib could be using poi() and read_gdbvalue(). Not sure if there is an established API deprecation mechanism for changes like this, or if you want to create one, or just accept that this may break stuff for external tooling. |
729df0e
to
d109dbd
Compare
@fidgetingbits needs a rebase. @disconnect3d are you good with the changes in this PR? |
015992e
to
db55b6f
Compare
db55b6f
to
e958747
Compare
rebased now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; @gsingh93 please merge if u are okay with those changes
These are some changes that I made while porting some musl mallocng functionality, but am breaking up PRs so that it's easier to manage. So this just exposes some new API that aren't yet being called anywhere.
Hopefully are intuitively named. If people have better ideas, I'm happy to change them. If we settle on something, we can change the read_gdbvalue() calls in a separate PR later.