Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

got command: possibility to filter results #284

Merged
merged 1 commit into from
May 22, 2017
Merged

got command: possibility to filter results #284

merged 1 commit into from
May 22, 2017

Conversation

disconnect3d
Copy link
Member

After the changes:

pwndbg> got write

GOT protection: Partial RELRO | GOT functions: 108
 
[00000061f280] fwrite_unlocked@GLIBC_2.2.5 -> 0x4026c6 (fwrite_unlocked@plt+6) ◂— push   0x4d /* 'hM' */
[00000061f330] fwrite@GLIBC_2.2.5 -> 0x402826 (fwrite@plt+6) ◂— push   0x63 /* 'hc' */
pwndbg> got
# 108 results here...

One thing I am not sure... Is it safe to remove OnlyWithFile when we have OnlyWhenRunning?
Can remote target not have a file under the hood?

@disconnect3d disconnect3d mentioned this pull request May 21, 2017
Merged
@degrigis
Copy link
Contributor

I like the idea, only refactor the code using the new code in #280 for wrappers when will be ready to merge :-)
I don't think remote target can be without a file, so I would say that OnlyWhenRunning is enough... @zachriggle ?

@zachriggle zachriggle merged commit dae257c into pwndbg:dev May 22, 2017
disconnect3d added a commit to disconnect3d/pwndbg that referenced this pull request Jul 29, 2018
@disconnect3d
Merge branch 'beta' into stable
2e77c5d 
* beta:
  Merge dev to beta (pwndbg#506)
  Better exception msg (pwndbg#300)
  handle window resize event and set width accordingly (pwndbg#291)
  Remove pwndbg/linkmap.py and malloc.py (pwndbg#303)
  Fix got command (pwndbg#306)
  Fire isort so travis won't complain (pwndbg#302)
  extend next_call to take optional symbol/target to break on (pwndbg#290)
  got command: possibility to filter results (pwndbg#284)
  ROPGadget: return when not installed (pwndbg#283)
  Fix parsed commands (pwndbg#282)
  added command 'got' to display status of the GOT table (pwndbg#256)
  Clean up some unnecessary closures in pwndbg.commands (pwndbg#278)
  Fix missing exception in pwndbg/exception.py (pwndbg#277)
  Fix input issue after screen resize: pagination off (pwndbg#276)
  Simplify command exception debugging and make stdio work correctly (pwndbg#251)
  Add Command.repeat property for repeated commands (pwndbg#272)
  support for multiple arenas (pwndbg#262)
  Fix Python2 long types and inthook (pwndbg#250)
  fixed GDB remote get command (pwndbg#241)
  Add CONTRIBUTING and ISSUE_TEMPLATE (pwndbg#238)
@disconnect3d disconnect3d deleted the got_command_filter_results branch July 29, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachriggle zachriggle zachriggle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disconnect3d @degrigis @zachriggle