Improve setup.sh distro and docker handling #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the OS is not detected/supported, try checking for apt/dnf.
disconnect3d
force-pushed
the
fix-setup
branch
from
0befc46
to
0898611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes setup.sh:
add a fake
sudofunction that just executes given program without sudo if we are in a docker container without sudo. To be more specific in a cases when:/.dockerenvfile existssudoprogram doesn't existwhoamireturnsrootadds a check for
archdistro and tells the user to install community packagemakes us fallback to checking for package manager if distro is not found: currently either
aptordnfThe latter should also fix #548