Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of changed editor #84

Closed
wants to merge 1 commit into from

Conversation

randshell
Copy link
Contributor

Previously right after loading the editor and doing a change like highlighting, then switching to another Audit section, changes aren't detected and so not saved. This change attempts to make the change detection more consistent.

Previously right after loading the editor and doing a change like highlighting, then switching to another Audit section, changes aren't detected and so not saved.
@Zeecka Zeecka requested a review from Serizao March 14, 2023 17:43
@Serizao
Copy link
Contributor

Serizao commented Mar 14, 2023

thanks for the PR @randomshell :) . The fix doesn't seem to work for me. I think it comes from the sync with WS because it triggers update type events. That's why my approach on this bug was to use a change counter with a memory of the number of changes after the end of the WS sync.

@randshell
Copy link
Contributor Author

randshell commented Mar 20, 2023

I did more tests and indeed this is not the solution. And I agree, as you've already seen, that there's something going on with the WS that affects this issue.

After some trial and error fixing the editor change detection, in my opinion it'd be worth to give #80 a try instead. I believe that by having real time saves there wouldn't be a need to check the editor for changes, so to me this would be the core issue. Additionally, this change would also be much more user friendly and help with the productivity.

@Serizao
Copy link
Contributor

Serizao commented Mar 20, 2023

Yes I agree with you. I'm not going to have much time in the next 2-3 weeks, I'll look at this after

@Serizao Serizao closed this Mar 20, 2023
@randshell
Copy link
Contributor Author

I appreciate it @Serizao. And I'm available if I can help for example with the testing side, as unfortunately I couldn't really figure out yet how to implement it myself.

@randshell randshell deleted the patch-2 branch March 20, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants