Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new base for docs #450

Merged

Conversation

PerchunPak
Copy link
Member

This is based on my template, but without sphinx-autoapi dependency. The reason for this is that mcstatus has explicitly defined the Public API, and we do not need to document the entire app in a quick way.

I also added this on top of current sphinx-docs changes, to not produce merge conflicts that will stop GitHub from merging this PR. I'm sure that there exists a better way, I'm open for ideas.

This PR also fixes some small "issues" in CONTRIBUTING.md and README.md, without them, sphinx will work incorrectly.

P.S. Some things from @kevinkjt2000's work were also added here.

pkg_meta = _get_project_meta()
project = str(pkg_meta["name"])
copyright = str(date.today().year) + ", py-mine"
author = "py-mine"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to still give attribution to dinnerbone here. I'll look for a way to add py-mine to the list in pyproject.toml and use pkg_meta["authors"] here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that you mentioned Dinnerbone as author before, here it was just generated value.

@kevinkjt2000 kevinkjt2000 merged commit 17e232f into py-mine:sphinx-docs Jan 1, 2023
@PerchunPak PerchunPak deleted the create-new-base-for-documentation branch January 1, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants