Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Dinnerbone as author #462

Conversation

PerchunPak
Copy link
Member

I'd like to still give attribution to dinnerbone here. I'll look for a way to add py-mine to the list in pyproject.toml and use pkg_meta["authors"] here.

Originally posted by @kevinkjt2000 in #450 (comment)

@ItsDrike
Copy link
Member

ItsDrike commented Jan 13, 2023

While Dinnerbone did author this project, I don't know if it's really fair to say that the copyright belongs to him, considering that at this point, not much of the code-base is actually his code anymore. I did some searching and found that from a total of ~3.9k lines of code, only 481 lines are still owned by Dinnerbone, which is just 12%. This number will also likely greatly decrease after some of the bigger PRs that are currently pending get merged.

image

I think that while Dinnerbone should be left in the author field, the copyright field can just stay as py-mine, giving credit to the whole development team of the project.

@ItsDrike ItsDrike added area: documentation Related to project's documentation (comments, docstrings, docs) type: rewrite Complete or partial rewrite of a part of the codebase labels Jan 13, 2023
@PerchunPak PerchunPak force-pushed the mention-dinnerbone-as-author-in-docs branch from dc673e5 to 8b8d72a Compare January 13, 2023 07:14
@kevinkjt2000
Copy link
Contributor

Copyrights can mention multiple people. Almost like a small history. Copyright protections last for 70 years.

@kevinkjt2000 kevinkjt2000 merged commit f863f07 into py-mine:sphinx-docs Jan 17, 2023
@PerchunPak PerchunPak deleted the mention-dinnerbone-as-author-in-docs branch January 17, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Related to project's documentation (comments, docstrings, docs) type: rewrite Complete or partial rewrite of a part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants