Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add color and font format to returned outline #1104

Merged
merged 3 commits into from Jul 14, 2022

Conversation

mtd91429
Copy link
Contributor

Closes #513

Suppress mypy error PdfObject has no attribute __iter__ rather than amend class
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1104 (c7ed347) into main (8f47939) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   91.59%   91.96%   +0.37%     
==========================================
  Files          24       24              
  Lines        4545     4657     +112     
  Branches      933      962      +29     
==========================================
+ Hits         4163     4283     +120     
+ Misses        241      229      -12     
- Partials      141      145       +4     
Impacted Files Coverage Δ
PyPDF2/_reader.py 91.46% <100.00%> (+0.06%) ⬆️
PyPDF2/generic.py 91.70% <100.00%> (+0.08%) ⬆️
PyPDF2/_page.py 92.13% <0.00%> (-0.61%) ⬇️
PyPDF2/_writer.py 88.72% <0.00%> (-0.31%) ⬇️
PyPDF2/constants.py 100.00% <0.00%> (ø)
PyPDF2/_cmap.py 93.54% <0.00%> (+9.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f47939...c7ed347. Read the comment docs.

@MartinThoma MartinThoma merged commit 5e1cc57 into py-pdf:main Jul 14, 2022
@MartinThoma
Copy link
Member

Thank you very much for your contribution - and for going through the hassle of splitting the PR up 🤗 I appreciate that a lot 🙏

mtd91429 added a commit to mtd91429/PyPDF2 that referenced this pull request Jul 15, 2022
@mtd91429 mtd91429 deleted the color_fmt branch July 16, 2022 21:14
MartinThoma added a commit that referenced this pull request Jul 17, 2022
New Features (ENH):
-  Add color and font_format to PdfReader.outlines[i] (#1104)
-  Extract Text Enhancement (whitespaces) (#1084)

Bug Fixes (BUG):
-  Use `build_destination` for named destination outlines (#1128)
-  Avoid a crash when a ToUnicode CMap has an empty dstString in beginbfchar (#1118)
-  Prevent deduplication of PageObject (#1105)
-  None-check in DictionaryObject.read_from_stream (#1113)
-  Avoid IndexError in _cmap.parse_to_unicode (#1110)

Documentation (DOC):
-  Explanation for git submodule
-  Watermark and stamp (#1095)

Maintenance (MAINT):
-  Text extraction improvements (#1126)
-  Destination.color returns ArrayObject instead of tuple as fallback (#1119)
-  Use add_bookmark_destination in add_bookmark (#1100)
-  Use add_bookmark_destination in add_bookmark_dict (#1099)

Testing (TST):
-  Remove xfail from test_outline_title_issue_1121
-  Add test for arab text (#1127)
-  Add xfail for decryption fail (#1125)
-  Add xfail test for IndexError when extracting text (#1124)
-  Add MCVE showing outline title issue (#1123)

Code Style (STY):
-  Apply black and isort
-  Use IntFlag for permissions_flag / update_page_form_field_values (#1094)
-  Simplify code (#1101)

Full Changelog: 2.5.0...2.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Return color/font/formatting information for outline/bookmarks
2 participants