Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if pdf variable is None #1113

Merged
merged 1 commit into from Jul 15, 2022
Merged

Check if pdf variable is None #1113

merged 1 commit into from Jul 15, 2022

Conversation

jlshin
Copy link
Contributor

@jlshin jlshin commented Jul 14, 2022

Closes #1107

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1113 (3bff9e5) into main (bb2d1db) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          24       24           
  Lines        4657     4657           
  Branches      962      962           
=======================================
  Hits         4283     4283           
  Misses        229      229           
  Partials      145      145           
Impacted Files Coverage Δ
PyPDF2/generic.py 91.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2d1db...3bff9e5. Read the comment docs.

@MartinThoma MartinThoma merged commit 9bbe827 into py-pdf:main Jul 15, 2022
@MartinThoma
Copy link
Member

Thank you very much ❤️

The fix is now in main. I will make a release to PyPI on Sunday (17.07.2022)

mtd91429 pushed a commit to mtd91429/PyPDF2 that referenced this pull request Jul 15, 2022
Guard pdf.strict with check if pdf is None in DictionaryObject.read_from_stream

Closes py-pdf#1107
MartinThoma added a commit that referenced this pull request Jul 17, 2022
New Features (ENH):
-  Add color and font_format to PdfReader.outlines[i] (#1104)
-  Extract Text Enhancement (whitespaces) (#1084)

Bug Fixes (BUG):
-  Use `build_destination` for named destination outlines (#1128)
-  Avoid a crash when a ToUnicode CMap has an empty dstString in beginbfchar (#1118)
-  Prevent deduplication of PageObject (#1105)
-  None-check in DictionaryObject.read_from_stream (#1113)
-  Avoid IndexError in _cmap.parse_to_unicode (#1110)

Documentation (DOC):
-  Explanation for git submodule
-  Watermark and stamp (#1095)

Maintenance (MAINT):
-  Text extraction improvements (#1126)
-  Destination.color returns ArrayObject instead of tuple as fallback (#1119)
-  Use add_bookmark_destination in add_bookmark (#1100)
-  Use add_bookmark_destination in add_bookmark_dict (#1099)

Testing (TST):
-  Remove xfail from test_outline_title_issue_1121
-  Add test for arab text (#1127)
-  Add xfail for decryption fail (#1125)
-  Add xfail test for IndexError when extracting text (#1124)
-  Add MCVE showing outline title issue (#1123)

Code Style (STY):
-  Apply black and isort
-  Use IntFlag for permissions_flag / update_page_form_field_values (#1094)
-  Simplify code (#1101)

Full Changelog: 2.5.0...2.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf set to None followed by an attribute check on pdf
2 participants