Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add xfail test for IndexError when extracting text #1124

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

MartinThoma
Copy link
Member

See #1091

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #1124 (a91dce7) into main (5ddf4cb) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   91.97%   92.01%   +0.04%     
==========================================
  Files          24       24              
  Lines        4661     4661              
  Branches      962      962              
==========================================
+ Hits         4287     4289       +2     
+ Misses        229      227       -2     
  Partials      145      145              
Impacted Files Coverage Δ
PyPDF2/_page.py 92.60% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ddf4cb...a91dce7. Read the comment docs.

@MartinThoma
Copy link
Member Author

Interestingly, this one now covers 2 more lines:

image

@MartinThoma MartinThoma merged commit b1d4ea1 into main Jul 17, 2022
@MartinThoma MartinThoma deleted the 1091-test branch July 17, 2022 07:58
MartinThoma added a commit that referenced this pull request Jul 17, 2022
New Features (ENH):
-  Add color and font_format to PdfReader.outlines[i] (#1104)
-  Extract Text Enhancement (whitespaces) (#1084)

Bug Fixes (BUG):
-  Use `build_destination` for named destination outlines (#1128)
-  Avoid a crash when a ToUnicode CMap has an empty dstString in beginbfchar (#1118)
-  Prevent deduplication of PageObject (#1105)
-  None-check in DictionaryObject.read_from_stream (#1113)
-  Avoid IndexError in _cmap.parse_to_unicode (#1110)

Documentation (DOC):
-  Explanation for git submodule
-  Watermark and stamp (#1095)

Maintenance (MAINT):
-  Text extraction improvements (#1126)
-  Destination.color returns ArrayObject instead of tuple as fallback (#1119)
-  Use add_bookmark_destination in add_bookmark (#1100)
-  Use add_bookmark_destination in add_bookmark_dict (#1099)

Testing (TST):
-  Remove xfail from test_outline_title_issue_1121
-  Add test for arab text (#1127)
-  Add xfail for decryption fail (#1125)
-  Add xfail test for IndexError when extracting text (#1124)
-  Add MCVE showing outline title issue (#1123)

Code Style (STY):
-  Apply black and isort
-  Use IntFlag for permissions_flag / update_page_form_field_values (#1094)
-  Simplify code (#1101)

Full Changelog: 2.5.0...2.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant