FIX : decode #23 in NameObject #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pending to confirmation from @sietzeberends that the bug is fixed |
Codecov Report
@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
- Coverage 94.72% 94.62% -0.10%
==========================================
Files 30 30
Lines 5118 5118
Branches 1052 1052
==========================================
- Hits 4848 4843 -5
- Misses 158 164 +6
+ Partials 112 111 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
All good! |
MartinThoma
reviewed
Sep 10, 2022
Co-authored-by: Martin Thoma <info@martin-thoma.de>
|
Thank you @pubpub-zz 🤗 |
|
don't forget to propose @sietzeberends as contributor, his reporting was excellent |
MartinThoma
added a commit
that referenced
this pull request
Sep 11, 2022
Bug Fixes (BUG): - Fix Error in transformations (#1341) - Decode #23 in NameObject (#1342) Testing (TST): - Use pytest.warns() for warnings, and .raises() for exceptions (#1325) Full Changelog: 2.10.6...2.10.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1340