Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Fix Error in transformations #1341

Merged
merged 1 commit into from Sep 10, 2022

Conversation

pubpub-zz
Copy link
Collaborator

Error detected during analysis of #1280

Error detected during analysis of py-pdf#1280
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #1341 (a5224c0) into main (0ceaa60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1341   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          30       30           
  Lines        5118     5118           
  Branches     1052     1052           
=======================================
  Hits         4848     4848           
  Misses        158      158           
  Partials      112      112           
Impacted Files Coverage Δ
PyPDF2/_page.py 94.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MartinThoma
Copy link
Member

Chapter "4.2.2 Common Transformations" and "4.2.3 Transformation Matrices" define the array structure.

image

@MartinThoma
Copy link
Member

That confirms that your PR is correct. Very good catch!

@MartinThoma MartinThoma merged commit 95012cc into py-pdf:main Sep 10, 2022
MartinThoma added a commit that referenced this pull request Sep 11, 2022
Bug Fixes (BUG):
-  Fix Error in transformations (#1341)
-  Decode #23 in NameObject (#1342)

Testing (TST):
-  Use pytest.warns() for warnings, and .raises() for exceptions (#1325)

Full Changelog: 2.10.6...2.10.7
@pubpub-zz pubpub-zz deleted the fix_transform_CTM branch June 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants