TST: Use pytest.warns() for warnings, and .raises() for exceptions #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the warning-as-exception checks with use of `pytest.warns()` that is more semantically correct and works correctly when the tests are run without -Werror (e.g. because -Werror tends to cause test suites to crash on irrelevant deprecation warnings from other components). While at it, replace the homegrown exception checks in test_orientations with `pytest.raises()`.
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 30 30
Lines 5097 5097
Branches 1049 1049
=======================================
Hits 4835 4835
Misses 153 153
Partials 109 109 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MartinThoma
changed the title
|
That looks a lot cleaner - good work 👍 |
|
If you want l'll add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) |
|
Thanks. I'm fine either way. |
MartinThoma
added a commit
that referenced
this pull request
Sep 11, 2022
Bug Fixes (BUG): - Fix Error in transformations (#1341) - Decode #23 in NameObject (#1342) Testing (TST): - Use pytest.warns() for warnings, and .raises() for exceptions (#1325) Full Changelog: 2.10.6...2.10.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the warning-as-exception checks with use of
pytest.warns()that is more semantically correct and works correctly when the tests
are run without -Werror (e.g. because -Werror tends to cause test suites
to crash on irrelevant deprecation warnings from other components).
While at it, replace the homegrown exception checks in test_orientations
with
pytest.raises().