Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPDF.write_html() now honors line-height attributes on <ol> & <li> elements #1141

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Apr 2, 2024

Context: #1116

@gmischler: could you please review this? 🙂

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.22%. Comparing base (148a1b6) to head (59ef531).

❗ Current head 59ef531 differs from pull request most recent head 6be1f56. Consider uploading reports for the commit 6be1f56 to get more accurate results

Files Patch % Lines
fpdf/html.py 82.14% 4 Missing and 1 partial ⚠️
fpdf/text_region.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   93.27%   93.22%   -0.05%     
==========================================
  Files          30       30              
  Lines        9228     9243      +15     
  Branches     2103     2104       +1     
==========================================
+ Hits         8607     8617      +10     
- Misses        379      384       +5     
  Partials      242      242              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C Lucas-C merged commit 356b6dd into master Apr 10, 2024
13 checks passed
@Lucas-C Lucas-C deleted the html-li-line-height branch April 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants