New Line After Header *Before* Font Change

[jkfitzsimons]

Currently, when exiting the h1/h2/etc tag the process was to first pop to the previous font and then create a new line (pdf.ln(self.h)). The problem is that if the head font is large and the previous font was significantly smaller, then the new line is not large enough to escape past the bottom of the head font. I've simple reversed this order and tested it locally - seems to work perfectly now for various header and non-header font sizes.

[Lucas-C]

Thanks for reporting this issue.

Sadly this seems to cause tests to fail...

FAILED test/html/test_html.py::test_html_features
FAILED test/html/test_html.py::test_html_headings_line_height
FAILED test/html/test_html.py::test_html_custom_heading_sizes
FAILED test/outline/test_outline_html.py::test_html_toc
FAILED test/outline/test_outline_html.py::test_html_toc_2_pages
FAILED test/outline/test_outline_html.py::test_html_toc_with_h1_as_2nd_heading
FAILED test/outline/test_outline_html.py::test_custom_HTML2FPDF

I haven't looked into it much, I only checked the CI pipeline logs.
You may want to run those tests locally on your side to figure if this PR causes any visual difference,
or if this is purely an imperceptible PDF binary change.

Also @jkfitzsimons: could you please provide some minimal code reproducing your issue,
so that we can add a unit test for it?

[jkfitzsimons]

Got it - I'll run the tests locally and share the comparison. I think it's just the assert pdf equal commands in the test will be slightly different, hence causing the CI fail.

[Lucas-C]

Hi @jkfitzsimons !

I haven't asked so far: would you like this PR be merged as part of hacktoberfest?
I will be less available this week-end to review & merge PRs, but I'll try to check things here on Sunday.

[jkfitzsimons]

Oh not at all, I only pushed it as it caused a problem for me and I figured may as well solve it for others too. Sorry for the delay in running the tests, I've been swamped with work but hoping to catch a breather shortly :)

[Lucas-C]

Ok, no worries then 😉
And good luck with work!

[Lucas-C]

Hi @jkfitzsimons !

Could you explain what issue this PR aims to fix?

Given this PR hasn't seen any activity over the past months, I may consider closing it...