Add arc and solid_arc method to FPDF

[tabarnhack]

According to #258, this PR adds the 2 methods arc and solid_arc.

arc and solid_arc methods allow to draw respectively an arc and a solid arc in a PDF file in a similar way to the rect, circle and ellipse methods.

Tests and documentation have also been improved in order to add these 2 features.

[tabarnhack]

I'm not sure where the test failed. Can you provide me with some details so that I can correct my mistake please ?

[Lucas-C]

Sure! And thanks for your contribution!

Seems like pylint is complaining because of the high similarities of the functions test_arc_line_width & test_solid_arc_line_width.
Feel free to add a # pylint: disable=duplicate-code on the definition line of those 2 functions.
That should get rid of this warning.

A side question: are you doing this for hacktoberfest?
Just to know if you're aiming to have this merged before the end of the month 😉

[tabarnhack]

Great ! Thanks for the tip I'm not familiar with pylint. I will make the changes to disable the errors as, even if the 2 functions are similar, they don't really have the same purposes.

Indeed, I'm participating to Hacktoberfest despite the late timing 😄

[tabarnhack]

Unfortunately, pylint seems to have an issue about disabling the duplicate-code rule for a piece of code as stated in the issue from the pylint project. I've tried several things but the error is triggered everytime.

[Lucas-C]

Damn.

A few ideas:

• try to place the comment on the very first line of both files
• try to slightly change the code of one of the function to avoid triggering the check
• try to create a test/.pylintrc that disables this check

If everything fails, I'm fine with disabling this check in the root .pylintrc
if it causes more annoying false positives than relevant warnings.

[Lucas-C]

@allcontributors please add @tabarnhack for code

[allcontributors]

@Lucas-C

I've put up a pull request to add @tabarnhack! 🎉

[tabarnhack]

Okay, I've found a workaround even if I'm not really proud of it 😅

[Lucas-C]

Nice!
You just need to-generate the reference PDF for test_solid_arc_line_width,
as it is now failing. Just passing generate=True once to assert_pdf_equal in this function should do the trick.

[codecov]

Codecov Report

Merging #266 (2df33ed) into master (75770cb) will increase coverage by 0.04%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   87.05%   87.09%   +0.04%     
==========================================
  Files          16       16              
  Lines        3753     3819      +66     
  Branches      805      814       +9     
==========================================
+ Hits         3267     3326      +59     
- Misses        315      319       +4     
- Partials      171      174       +3     

Impacted Files	Coverage Δ
fpdf/fpdf.py	83.86% <87.87%> (+0.20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75770cb...2df33ed. Read the comment docs.

[Lucas-C]

You did an excellent job here!
The code, the doc and the tests are great.
I suggested some minor changes.
Could you also please a short mention of your addition to CHANGELOG.md?

[Lucas-C]

Perfect!

I merged your PR, thank you for your contribution!

[Lucas-C]

FYI I mentioned you in this blog article 😉
https://chezsoi.org/lucas/blog/hacktoberfest-on-fpdf2.html