Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG stroke-width with explicit unit, fixes #526 #542

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

gmischler
Copy link
Collaborator

e.g. Fixes #526

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.
  • A unit test is covering the code added / modified by this PR
  • This PR is ready to be merged
  • [NA] In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder
  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #542 (8ddd5b7) into master (54b0309) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   94.10%   93.97%   -0.13%     
==========================================
  Files          22       22              
  Lines        6206     6073     -133     
  Branches     1265     1232      -33     
==========================================
- Hits         5840     5707     -133     
  Misses        191      191              
  Partials      175      175              
Impacted Files Coverage Δ
fpdf/svg.py 95.94% <100.00%> (+0.02%) ⬆️
fpdf/prefs.py 90.90% <0.00%> (-1.95%) ⬇️
fpdf/drawing.py 92.73% <0.00%> (-0.28%) ⬇️
fpdf/syntax.py 95.37% <0.00%> (-0.05%) ⬇️
fpdf/fpdf.py 92.56% <0.00%> (-0.01%) ⬇️
fpdf/sign.py 100.00% <0.00%> (ø)
fpdf/enums.py 100.00% <0.00%> (ø)
fpdf/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Perfect PR!
Thank you @gmischler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.svg from plotly cannot be parsed - stroke-width with length in px should be allowed
2 participants