Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolve_length in ShapeBuilder.rect #558

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Use resolve_length in ShapeBuilder.rect #558

merged 3 commits into from
Sep 28, 2022

Conversation

darioackermann
Copy link

@darioackermann darioackermann commented Sep 25, 2022

Provides a tiny fix to #555

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C
Copy link
Member

Lucas-C commented Sep 25, 2022

Thank you for submitting a PR!
Would you mind adding a mention of this fix in CHANGELOG.md, and also a small unit test please?
You can just add an entry here: https://github.com/PyFPDF/fpdf2/blob/master/test/svg/parameters.py#L73

@darioackermann darioackermann marked this pull request as ready for review September 26, 2022 12:44
@darioackermann
Copy link
Author

Added a Test and documented in Changelog. Should there any change be necessary, just let me know.

CHANGELOG.md Show resolved Hide resolved
test/svg/parameters.py Show resolved Hide resolved
@Lucas-C
Copy link
Member

Lucas-C commented Sep 28, 2022

Your PR is fine but the GitHub Actions pipeline is currently blocked by #559
I'll try to fix this asap and you'll just have to rebase your branch

@darioackermann
Copy link
Author

Sure, no stress! I'll watch #559 and rebase accordingly

@Lucas-C
Copy link
Member

Lucas-C commented Sep 28, 2022

The issue #559 is fixed now

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 94.07% // Head: 94.07% // No change to project coverage 👍

Coverage data is based on head (cc94552) compared to base (cc94552).
Patch has no changes to coverable lines.

❗ Current head cc94552 differs from pull request most recent head 63cfbef. Consider uploading reports for the commit 63cfbef to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          21       21           
  Lines        6124     6124           
  Branches     1250     1250           
=======================================
  Hits         5761     5761           
  Misses        189      189           
  Partials      174      174           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C merged commit 9131996 into py-pdf:master Sep 28, 2022
@Lucas-C
Copy link
Member

Lucas-C commented Sep 28, 2022

I rebased and based your branch
Thank you @darioackermann!

@darioackermann
Copy link
Author

Thanks for rebasing, I was a bit short of time today. You're welcome!

@darioackermann darioackermann deleted the dac/555-parsing-errors-in-shapebuilder-rect-and-convert-stroke-width branch September 28, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants