Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skew function #656

Merged
merged 9 commits into from
Jan 2, 2023
Merged

Skew function #656

merged 9 commits into from
Jan 2, 2023

Conversation

erap129
Copy link

@erap129 erap129 commented Dec 31, 2022

Added skew function (according to issue #536). Very similar to rotation.
Not sure where the documentation is supposed to go (I probably put it in the wrong place)
Opened a new PR instead of the old one that dealt with text only.

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@erap129 erap129 marked this pull request as ready for review December 31, 2022 13:05
@Lucas-C Lucas-C mentioned this pull request Jan 2, 2023
5 tasks
Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great!
I'm going to perform a new release once this nice addition has landed on the master branch 😃
Thank you for your contribution @erap129

CHANGELOG.md Outdated Show resolved Hide resolved
docs/PageFormatAndOrientation.md Outdated Show resolved Hide resolved
@Lucas-C Lucas-C merged commit 8081eea into py-pdf:master Jan 2, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Jan 2, 2023

@allcontributors please add @erap129 for code

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @erap129! 🎉

@Lucas-C
Copy link
Member

Lucas-C commented Jan 2, 2023

Thank you @erap129 for your contribution!
Good job

@Lucas-C
Copy link
Member

Lucas-C commented Jan 4, 2023

Out of curiosity, what made you want to contribute this PR to fpdf2? 😊

@erap129
Copy link
Author

erap129 commented Jan 7, 2023

Out of curiosity, what made you want to contribute this PR to fpdf2? blush

I reached you through the up-for-grabs hashtag and it seemed like a cool repo :)

@Lucas-C
Copy link
Member

Lucas-C commented Jan 7, 2023

I reached you through the up-for-grabs hashtag and it seemed like a cool repo :)

Ahaha, great! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants