-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skew function #656
Skew function #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great!
I'm going to perform a new release once this nice addition has landed on the master
branch 😃
Thank you for your contribution @erap129
@allcontributors please add @erap129 for code |
I've put up a pull request to add @erap129! 🎉 |
Thank you @erap129 for your contribution! |
Out of curiosity, what made you want to contribute this PR to fpdf2? 😊 |
I reached you through the up-for-grabs hashtag and it seemed like a cool repo :) |
Ahaha, great! 😄 |
Added skew function (according to issue #536). Very similar to rotation.
Not sure where the documentation is supposed to go (I probably put it in the wrong place)
Opened a new PR instead of the old one that dealt with text only.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.