Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #693 (v2) #707

Closed
wants to merge 1 commit into from
Closed

fix for #693 (v2) #707

wants to merge 1 commit into from

Conversation

eroux
Copy link

@eroux eroux commented Feb 23, 2023

fixes #693

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@eroux eroux requested a review from Lucas-C as a code owner February 23, 2023 11:17
@eroux eroux changed the title restart fix-693 branch fix for #693 (v2) Feb 23, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Feb 23, 2023

Closed in favor of #706

@Lucas-C Lucas-C closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: avoid altering images passed to FPDF.image() if there is no need to
2 participants