Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling some edge cases with table() #768

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Handling some edge cases with table() #768

merged 2 commits into from
Apr 19, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Apr 14, 2023

Added

  • FPDF.write_html(): <table> elements can now be aligned left or right on the page using align=

Fixed

  • FPDF.table(): text overflow in the last cell of the header row is now properly handled
  • FPDF.table(): when align="RIGHT" is provided, the page right margin is now properly taken in consideration

Deprecated

  • the split_only optional parameter of FPDF.multi_cell(), which is replaced by two new distincts optional parameters: dry_run & output

@Lucas-C Lucas-C marked this pull request as draft April 14, 2023 13:22
@Lucas-C Lucas-C changed the title Draft: Handling some edge cases with table() Handling some edge cases with table() Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.04 🎉

Comparison is base (28edd82) 93.15% compared to head (14a0947) 93.19%.

❗ Current head 14a0947 differs from pull request most recent head d84809a. Consider uploading reports for the commit d84809a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   93.15%   93.19%   +0.04%     
==========================================
  Files          27       27              
  Lines        7285     7286       +1     
  Branches     1322     1322              
==========================================
+ Hits         6786     6790       +4     
+ Misses        312      309       -3     
  Partials      187      187              
Impacted Files Coverage Δ
fpdf/table.py 92.41% <50.00%> (+1.42%) ⬆️
fpdf/html.py 93.03% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C marked this pull request as ready for review April 19, 2023 19:00
@Lucas-C Lucas-C force-pushed the table-fixups branch 2 times, most recently from 550ffc9 to b98c721 Compare April 19, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant