Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing image insertion in tables #773

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Fixing image insertion in tables #773

merged 2 commits into from
Apr 20, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Apr 20, 2023

Fixes some remaining bugs following PR #768

@Lucas-C Lucas-C changed the title Fixing image inertion in tables - fix #771 Fixing image insertion in tables - fix #771 Apr 20, 2023
@Lucas-C Lucas-C changed the title Fixing image insertion in tables - fix #771 Fixing image insertion in tables Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (851eaa3) 93.21% compared to head (fffef92) 93.22%.

❗ Current head fffef92 differs from pull request most recent head 247a217. Consider uploading reports for the commit 247a217 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   93.21%   93.22%   +0.01%     
==========================================
  Files          27       27              
  Lines        7308     7311       +3     
  Branches     1323     1322       -1     
==========================================
+ Hits         6812     6816       +4     
  Misses        309      309              
+ Partials      187      186       -1     
Impacted Files Coverage Δ
fpdf/fpdf.py 92.38% <100.00%> (+0.06%) ⬆️
fpdf/table.py 92.27% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C merged commit bdd4638 into master Apr 20, 2023
@Lucas-C Lucas-C deleted the imgs-in-tables branch April 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant