We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PdfMerger is used in the in the cat subcommand: https://github.com/py-pdf/pdfly/blob/main/pdfly/cat.py#L51
PdfMerger
cat
But this class is deprecated in pypdf since version 3.9.1: https://github.com/py-pdf/pypdf/releases/tag/3.9.1
pypdf
We should replace it by combining PdfReader, its merge_page() method & PdfWriter from pypdf. An example of code using those can be found there: https://py-pdf.github.io/fpdf2/CombineWithPypdf.html
PdfReader
merge_page()
PdfWriter
Extra unit tests could be added in the process in https://github.com/py-pdf/pdfly/blob/main/tests/test_cat.py in order to ensure that pdfly cat still works similarly as it currently does.
pdfly cat
The text was updated successfully, but these errors were encountered:
MAINT: In the cat subcommand, replace the usage of the deprecated Pdf…
f31111c
…Merger by PdfWriter (#34) Replaced the deprecated pypdf.PdfMerger with pypdf.PdfReader Closes #31
Successfully merging a pull request may close this issue.
PdfMerger
is used in the in thecat
subcommand: https://github.com/py-pdf/pdfly/blob/main/pdfly/cat.py#L51But this class is deprecated in
pypdf
since version 3.9.1: https://github.com/py-pdf/pypdf/releases/tag/3.9.1We should replace it by combining
PdfReader
, itsmerge_page()
method &PdfWriter
frompypdf
.An example of code using those can be found there: https://py-pdf.github.io/fpdf2/CombineWithPypdf.html
Extra unit tests could be added in the process in https://github.com/py-pdf/pdfly/blob/main/tests/test_cat.py
in order to ensure that
pdfly cat
still works similarly as it currently does.The text was updated successfully, but these errors were encountered: