MAINT: In the cat subcommand, replace the usage of the deprecated PdfMerger by PdfWriter #34
Conversation
|
Good job @kommade! I just approved this PR. By the way, are you contributing as part of https://hacktoberfest.com @kommade? |
|
@MartinThoma : do you think that this could be merged? 🙂 |
Lucas-C
changed the title
MartinThoma
changed the title
|
@kommade I'm very sorry that it took me so long to review / merge this PR 🙈 I remember that I had a quick glance, but wanted to add a few tests. Then I didn't have time for that and forgot 😅 Good work with the PR! There was a small off-by-one that was easy to fix with more tests. Your contribution will be on PyPI latest tomorrow :-) |
|
@Lucas-C Thank you for pinging me about this 🤗 And also for your help with the other issues/PRs/discussions ❤️ |
## What's new ### New Features (ENH) - Add x2pdf command (#25) by @MartinThoma ### Bug Fixes (BUG) - boxes are floats, not int by @MartinThoma - Add missing fpdf2 dependency (#29) by @MartinThoma ### Documentation (DOC) - cat command by @MartinThoma - More examples for the cat subcommand by @MartinThoma - Add cat subcommand by @MartinThoma - Link to readthedocs by @MartinThoma - Add project governance file by @MartinThoma - Move readthedocs config file to root by @MartinThoma - Add docs (#24) by @MartinThoma ### Developer Experience (DEV) - Checkout sample-files in CI (#30) by @MartinThoma - Let dependabot update Github Actions by @MartinThoma - Add action for automatic releases by @MartinThoma ### Maintenance (MAINT) - Update dependencies (#42) by @MartinThoma - In the cat subcommand, replace the usage of the deprecated PdfMerger by PdfWriter (#34) by @kommade - Update .pre-commit-config.yaml by @MartinThoma - Adjust x2pdf syntax by @MartinThoma ### Testing (TST) - cat with two files (#41) by @MartinThoma - Test cat command with more parameters + validate result (#40) by @MartinThoma - Adding unit tests (#28) by @Lucas-C [Full Changelog](0.2.14...0.3.0)
|
Hi! I actually just wanted to try contributing to public projects on github and it just happened to be hacktoberfest too! I'm glad it was accepted, no worries on the delay I wasn't too concerned anyway |
Removed deprecated PdfMerger as in #31 and replaced with PdfReader and PdfWriter. No changes made to test_case as functionality seems to be exactly the same.
Closes #31