ROB: Prevent loop in Cloning #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes py-pdf#1767 the issue is due to object 589/0 : this object corresponds to 2 object the file trailer but also an XObject corresponding to the filled text ("test") because of that the object tries to be duplicated inducing the loop. This loop is not normal and I've fixed as a robustness improvement. If you run your code the text "test" will be missing as it is hidden by the trailer object.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 34 34
Lines 6576 6581 +5
Branches 1301 1302 +1
=======================================
+ Hits 6077 6082 +5
Misses 326 326
Partials 173 173
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@MartinThoma all yours :) |
MartinThoma
changed the title
|
Thank you 🤗 |
MartinThoma
added a commit
that referenced
this pull request
Apr 9, 2023
Security (SEC): - Warn about PDF encryption security (#1755) Robustness (ROB): - Prevent loop in Cloning (#1770) - Capture UnicodeDecodeError at PdfReader.pdf_header (#1768) Documentation (DOC): - Pin myst_parser==0.16.1 and rename .readthedocs.yaml (#1752) - Add readthedocs.yml and bump docs dependencies using `tox -e deps` (#1750) Developer Experience (DEV): - Make make_changelog.py idempotent Maintenance (MAINT): - Move generation of file identifiers to a method (#1760) Testing (TST): - Add xmp test (#1775) Code Style (STY): - Improve language, add docstrings, fix TODOs (#1772) - Test names, docstrings, and parametrization (#1771) [Full Changelog](3.7.0...3.7.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1767
the issue is due to object 589/0 : this object corresponds to 2 object the file trailer but also an XObject corresponding to the filled text ("test") because of that the object tries to be duplicated inducing the loop. This loop is not normal and I've fixed as a robustness improvement. If you run your code the text "test" will be missing as it is hidden by the trailer object.