Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Prepare for adding AES enryption support #1818

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Conversation

MartinThoma
Copy link
Member

This PR makes #1816 a bit smaller

Full credit goes to @exiledkingcc

Full credit goes to exiledkingcc

Co-authored-by: exiledkingcc <exiledkingcc@gmail.com>
@MartinThoma MartinThoma added workflow-encryption From a users perspective, encryption is the affected feature/workflow is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements labels Apr 30, 2023
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.01 ⚠️

Comparison is base (6053167) 93.39% compared to head (0869949) 93.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
- Coverage   93.39%   93.39%   -0.01%     
==========================================
  Files          34       34              
  Lines        6614     6612       -2     
  Branches     1301     1297       -4     
==========================================
- Hits         6177     6175       -2     
  Misses        285      285              
  Partials      152      152              
Impacted Files Coverage Δ
pypdf/_encryption.py 91.73% <90.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit a6b628a into main Apr 30, 2023
@MartinThoma MartinThoma deleted the encryption-cleanup branch April 30, 2023 08:51
MartinThoma added a commit that referenced this pull request May 21, 2023
New Features (ENH)
-  Simplify metadata input (Document Information Dictionary) (#1851)
-  Extend cmap compatibilty to GBK_EUC_H/V (#1812)

Bug Fixes (BUG)
-  Prevent infinite loop when no character follows after a comment (#1828)
-  get_contents does not return ContentStream (#1847)
-  Accept XYZ destination with zoom missing (default to zoom=0.0) (#1844)
-  Cope with 1 Bit images (#1815)

Robustness (ROB)
-  Handle missing /Type entry in Page tree (#1845)

Documentation (DOC)
-  Expand file size explanations (#1835)
-  Add comparison with pdfplumber (#1837)
-  Clarify that PyPDF2 is dead (#1827)
-  Add Hunter King as Contributor for #1806

Maintenance (MAINT)
-  Refactor internal Encryption class (#1821)
-  Add R parameter to generate_values (#1820)
-  Make encryption_key parameter of write_to_stream optional (#1819)
-  Prepare for adding AES enryption support (#1818)

Code Style (STY):
-  Iterate directly over the list instead of using range (#1839)
-  Minor refactorings in _encryption.py (#1822)

[Full Changelog](3.8.1...3.9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements workflow-encryption From a users perspective, encryption is the affected feature/workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant