Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update references to the PDF specification #2638

Closed
wants to merge 7 commits into from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented May 13, 2024

Also change TABLE to table

pypdf/constants.py Outdated Show resolved Hide resolved
pypdf/constants.py Outdated Show resolved Hide resolved
pypdf/constants.py Outdated Show resolved Hide resolved
pypdf/constants.py Outdated Show resolved Hide resolved
@stefan6419846
Copy link
Collaborator

Could you please fix the merge conflicts?

j-t-1 and others added 6 commits May 13, 2024 10:54
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (a435eaa) to head (2b17e02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          50       50           
  Lines        8328     8328           
  Branches     1669     1669           
=======================================
  Hits         7909     7909           
  Misses        260      260           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-t-1
Copy link
Contributor Author

j-t-1 commented May 14, 2024

@stefan6419846 completely confused by this process. I must have done something wrong yesterday, as today's commit says

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

and has code outside of what I was changing.

I will do a completely new pull request with the changes instead, and once done you can discard this one without merging it.

@stefan6419846
Copy link
Collaborator

@j-t-1 Doesn't look https://github.com/py-pdf/pypdf/pull/2638/files correct? It's just the merge commit which shows the behavior you describe, but this should not really be an issue if the overall diff looks correctly as we are squashing your commits anyway.

@j-t-1
Copy link
Contributor Author

j-t-1 commented May 14, 2024

@j-t-1 Doesn't look https://github.com/py-pdf/pypdf/pull/2638/files correct? It's just the merge commit which shows the behavior you describe, but this should not really be an issue if the overall diff looks correctly as we are squashing your commits anyway.

I did a new one, please could you delete or close this one? I think this one was started in a detached state or something like that.

@stefan6419846
Copy link
Collaborator

Closing as duplicate of #2640.

@j-t-1 j-t-1 deleted the documentation branch May 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants