-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update references to the PDF specification #2638
Conversation
Also change TABLE to table
Could you please fix the merge conflicts? |
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 50 50
Lines 8328 8328
Branches 1669 1669
=======================================
Hits 7909 7909
Misses 260 260
Partials 159 159 ☔ View full report in Codecov by Sentry. |
@stefan6419846 completely confused by this process. I must have done something wrong yesterday, as today's commit says
and has code outside of what I was changing. I will do a completely new pull request with the changes instead, and once done you can discard this one without merging it. |
@j-t-1 Doesn't look https://github.com/py-pdf/pypdf/pull/2638/files correct? It's just the merge commit which shows the behavior you describe, but this should not really be an issue if the overall diff looks correctly as we are squashing your commits anyway. |
I did a new one, please could you delete or close this one? I think this one was started in a detached state or something like that. |
Closing as duplicate of #2640. |
Also change TABLE to table