STY: Small readability increases

[j-t-1]

Also remove unused DEFAULT_ANNOTATION_FLAG.

[j-t-1]

Python 3.8 added an = specifier to f-strings. This PR should work when Python 3.7 support is removed.

[stefan6419846]

I disagree with these changes and suggest closing it. Rationale:

• Having boolean variables with the is_ prefix is fine and increases readability by making it clear that it is a boolean by just looking at the name.
• Unnecessarily dropping support for Python 3.7 for the sake of removing 20 characters (22 characters if taking into account that the equivalent call without the new formatting requires an additional !r) does not feel right.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (38f3925) to head (38f3554).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2781      +/-   ##
==========================================
- Coverage   95.12%   95.11%   -0.01%     
==========================================
  Files          51       51              
  Lines        8547     8545       -2     
  Branches     1705     1705              
==========================================
- Hits         8130     8128       -2     
  Misses        263      263              
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[j-t-1]

Removed the = specifier to f-strings.

The name change makes
if not is_external and not is_internal:
quicker to parse
if not external and not internal:

[stefan6419846]

I do not really see the benefit you mention, thus I am going to keep this open for now.

[pubpub-zz]

agree with @stefan6419846