Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modified version of the auto MPG dataset #1190

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented May 22, 2024

Before, we were loading it directly from the UCI dataset repository. However, this cause connection issues and build fails. The dataset is now added directly with its respective license.

Further, removed the output of the causal discovery example notebook to ensure that it gets compiled while building.

Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this, @bloebp. Right now, the license file is in the root directory with many other example notebooks. Would it be cleaner to create a new directory called datasets/auto-mpg or and then add both the csv and license file in that sub-folder? The only code change will be to specify the correct path in the notebook.

Before, we were loading it directly from the UCI dataset repository. However, this cause connection issues and build fails. The dataset is now added directly with its respective license.

Further, removed the output of the causal discovery example notebook to ensure that it gets compiled while building.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
@bloebp
Copy link
Member Author

bloebp commented May 29, 2024

thanks for adding this, @bloebp. Right now, the license file is in the root directory with many other example notebooks. Would it be cleaner to create a new directory called datasets/auto-mpg or and then add both the csv and license file in that sub-folder? The only code change will be to specify the correct path in the notebook.

Makes sense! We probably should even move all datasets into that folder. But that should be a follow-up PR.

@amit-sharma amit-sharma merged commit 5d8fdd0 into main Jun 4, 2024
26 checks passed
@amit-sharma amit-sharma deleted the add_auto_mpg_dataset branch June 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants