Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - add a responder similar to what ROS has for approve package #16

Open
lwasser opened this issue Mar 14, 2024 · 2 comments
Open
Labels
question Further information is requested

Comments

@lwasser
Copy link
Member

lwasser commented Mar 14, 2024

Hi! ropensci has an approve responder which we could use as well.

Their responder does the following. :

ROpenSci :: Approve
This responder is used to approve a package. It performs a series of tasks:

Adds date-accepted to the body of the issue

Clears reviewers’ current_assignment in AirTable

Creates a new team named like the package-name and invites the creator of the issue to it (owner right needed)

Can reply with a template

Allows labeling

Closes the issue

If the submission-type is stats it checks if stasgrade is present and if so adds the proper label

We'd likely want a subset of this

pyOS Approve

This responder is used to approve a package. It performs a series of tasks:

  • Adds date-accepted to the header body of the issue
  • Can reply with a template and ingest templated data items into the template such as package-name, reviewer names and author name.
  • Allows labeling

How hard would it be to reuse their responder and just remove some of the fancy things such as airtable @xuanxu

@lwasser lwasser added the question Further information is requested label Mar 14, 2024
@xuanxu
Copy link
Member

xuanxu commented Mar 15, 2024

We can easily have a custom responder for pyOS based on this one.
Actually as we want a lot of commands to interact with a GitHub project board, probably all of the responders we end up using will be custom, based on existing ones but adding or tweaking something.

@lwasser
Copy link
Member Author

lwasser commented Mar 15, 2024

thanks @xuanxu i've thought about this more. Now that i see how this works and is setup i'm wondering if we want to stick to the built in responders as much as possible and then add things that i know we'll need (such as the approve responded that ros has - that makes sense). Seeing the challenges that i've already faced in getting the configuration correct 😆 it could make more sense for pyOS to work with mostly things that already exist, customize where it makes most sense (ie approve command and maybe how the issue is setup as we had discussed with the html tags) and then see how that works. i'm leaning that way now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants