Fix: Add categories validator to model #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
approved these changes
Feb 25, 2024
| """ | ||
|
|
||
| valid_categories = { | ||
| "data-processing": "data-processing-munging", |
There was a problem hiding this comment.
Small tip: If you alphabetize these categories, they will be easier to scan. Also in the docstring.
There was a problem hiding this comment.
oh - good suggestion. i can fix that before we merge. it's a small fix and you're right more readable!
lwasser
force-pushed
the
fix-categories
branch
from
2d8c277
to
ae01108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #105
Opening as a draft as it still needs tests but this adds a validation step to categories to ensure they are added to the final yaml file in a clean format with only dashes in between words for easier web parsing.