Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: pagination support for issue requests #140

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 19, 2024

A pr to support pagination when we fetch issues.
Working locally on summary values for total submissions over time, etc

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 58.95%. Comparing base (b368421) to head (355c7dd).

Files Patch % Lines
src/pyosmeta/github_api.py 10.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   60.55%   58.95%   -1.60%     
==========================================
  Files           8        8              
  Lines         502      519      +17     
  Branches       79       82       +3     
==========================================
+ Hits          304      306       +2     
- Misses        193      208      +15     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwasser
Copy link
Member Author

lwasser commented Mar 20, 2024

this pr is actually working really well now! its "failing" because of a decrease in test coverage not because of failing tests.

@lwasser
Copy link
Member Author

lwasser commented Mar 20, 2024

I am going to merge this. I think the tests for these api calls are more involved and i'd like to do it in a separate pr. i'll open an issue for that so we have the functionality for this now.

@lwasser lwasser merged commit a76ba97 into pyOpenSci:main Mar 20, 2024
2 of 4 checks passed
@lwasser lwasser deleted the rate-limiting branch March 20, 2024 23:46
@willingc
Copy link
Collaborator

willingc commented Mar 27, 2024

Closes #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants