Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: more specific community partners page with FAQ #253

Merged
merged 19 commits into from
Oct 31, 2023

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Sep 18, 2023

This is a new partners page that addresses all of the questions that I feel like i've been answering! I may have missed some so welcome any and all reviews from folks.

@lwasser
Copy link
Member Author

lwasser commented Oct 10, 2023

hi friends - would love some review from some of our partners here!

@pllim @jibarnum @mikelkou can you please have a look here and share this with anyone who may be interested in reading our general overview / policy page on what peer review partnerships look like?

i'm trying to capture all of the discussions, questions etc that we've collectively had into a single document that can be useful to everyone. many thanks

@pllim
Copy link
Contributor

pllim commented Oct 12, 2023

Thanks for the ping. I'll put this on my queue. I am also pinging Astropy editors, @dhomeier and @WilliamJamieson. 🙏

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think overall this is consistent with what Astropy is thinking over at astropy/astropy-APEs#87 . I will cross-link this PR over there.

Just some minor comments/questions.

@@ -1,4 +1,4 @@
# pyOpenSci Software Peer Review Partnerships
# Scientific Python Partnerships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scientific Python here means https://scientific-python.org/ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh no i mean as in we partner with scientific Python communities such as astropy. so lower case "s" rather than the project. maybe i could write:

Partnerships with Scientific Python communities?

would that be more clear?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. If I didn't know what is "Scientific Python" and I search that term on the Internet, I would still think it is that other org.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i follow. so perhaps just

pyOpenSci Community Peer Review Partnerships - closer to how it was initially is best?

partners/scientific-communities.md Outdated Show resolved Hide resolved
partners/scientific-communities.md Outdated Show resolved Hide resolved
partners/scientific-communities.md Outdated Show resolved Hide resolved

**Coming in 2024**

1. Access to metric dashboards for all accepted packages in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbered list does not quite make sense here unless you plan to add more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. i'll edit that locally. we also will be implementing a review bot.

partners/scientific-communities.md Outdated Show resolved Hide resolved
@pllim
Copy link
Contributor

pllim commented Oct 16, 2023

Not sure what is going on in the CI.

For the Links > External check, the following failures were found:

* At ./_build/html/how-to/review-triage-team.html:640:

  External link https://docs.google.com/spreadsheets/d/1jEk-DDpkz14Z07OX_o1cN2vHzVbJO6mQ83ihGXsWkLc/edit#gid=0 failed (status code 401)

* At ./_build/html/partners/pangeo.html:554:

  External link https://docs.2i2c.org/data/cloud/#cloud-native-formats failed (status code 404)

pllim added a commit to pllim/astropy-APEs that referenced this pull request Oct 16, 2023
@mikelkou
Copy link

mikelkou commented Oct 22, 2023

Hello I will try to ping some more people and have a look asap. @grst, @Zethson, @ivirshup

@lwasser
Copy link
Member Author

lwasser commented Oct 23, 2023

Not sure what is going on in the CI.

For the Links > External check, the following failures were found:

* At ./_build/html/how-to/review-triage-team.html:640:

  External link https://docs.google.com/spreadsheets/d/1jEk-DDpkz14Z07OX_o1cN2vHzVbJO6mQ83ihGXsWkLc/edit#gid=0 failed (status code 401)

* At ./_build/html/partners/pangeo.html:554:

  External link https://docs.2i2c.org/data/cloud/#cloud-native-formats failed (status code 404)

I will look into that! the google doc links need to be removed and the 2i2c page - perhaps it has moved. i'll look into this and fix things while also merging your suggestions and cleaning up text!! thanks so much for the review here.

lwasser and others added 4 commits October 23, 2023 12:29
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@lwasser lwasser mentioned this pull request Oct 23, 2023
Copy link
Contributor

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

appendices/editor-in-chief-checks.md Outdated Show resolved Hide resolved
partners/scientific-communities.md Outdated Show resolved Hide resolved
lwasser and others added 2 commits October 24, 2023 15:48
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
@lwasser
Copy link
Member Author

lwasser commented Oct 24, 2023

@all-contributors please add @pllim for code, review

@allcontributors
Copy link
Contributor

@lwasser

@pllim already contributed before to code, review

@lwasser
Copy link
Member Author

lwasser commented Oct 24, 2023

@all-contributors please add @grst for code, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @grst! 🎉

@lwasser
Copy link
Member Author

lwasser commented Oct 26, 2023

Hi everyone 👋 i think i've largely addressed all of the comments here (thank you for the input here!). this PR has been open since September 18. let's plan to merge it by next Monday October 30th.

Please leave any last comments in prior to then.

NOTE: our entire peer review guide is seen as a living document that can be changed over time as we grow and recognize other issues. Thus, please know you can also review the live page and open issues if you see missing / incorrect / confusing information after monday the 30th of october!

Also please have a look at our website new partner page . Once we formalized partnerships i'll be sure to include a list of partners with your logos and then links to each partners page on our website.

but for now it contains an overview of what a partnership looks like.

@lwasser
Copy link
Member Author

lwasser commented Oct 31, 2023

ok colleagues! i've addressed (i believe) all of the comments in this pull request! i am going to merge this document. BUT if you catch issues with it after it has gone online, please just open a new ISSUE in this repo and we can address it together. This is a living document that will evolve over time as we build our partnership together and learn about challenges and needs! thank you all for the help in bringing this process together!

@lwasser lwasser merged commit 4f88a6a into pyOpenSci:main Oct 31, 2023
3 checks passed
@lwasser lwasser deleted the partners2 branch October 31, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants