Repository base architecture #1
Conversation
- add quantum wrapper - update dependency and setup file
gcattan
changed the title
|
Good idea to separate the base from the code wrapper. |
setup.py
Outdated
| url='https://pyriemann.readthedocs.io', | ||
| author='Alexandre Barachant', | ||
| author_email='alexandre.barachant@gmail.com', |
There was a problem hiding this comment.
Sure. Can you please tell me how to deploy the docs once the artifact is generated, and if I should reserve the url name and to which provisioner?
Please, confirm also the name of the authors and how it is suitable to give credit for your work.
There was a problem hiding this comment.
@sylvchev , can you test the documentation deployment?
| @@ -0,0 +1,200 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Instead of a copy-paste this file from pyRiemann, is it possible to import conftest from pyRiemann dependency (for example, with from pyriemann.tests import conftest)? @sylvchev
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
add link to issue in the example gallery
- update conf pyRiemann -> pyRiemann-qiskit - remove example in index (as not yet available)
|
@sylvchev @qbarthelemy thanks for your valuable comments and suggestion. I updated the documentation and opened issue #4 to update the documentation with example and API reference once #2 is reviewed. You can download the last documentation build from this link: https://github.com/gcattan/pyRiemann-qiskit/actions/runs/1281835577 I did not address yet the |
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
|
@qbarthelemy Thank you for your comments and for providing edit suggestions. |
|
Nice work! |
Issue:
pyRiemann/pyRiemann#141
This PR provides the architecture repository, with an updated list of references.
Implementation of the Qiskit wrapper will be raised in another PR for the purpose of clarity.