Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qiskit wrapper #3

Closed
wants to merge 482 commits into from
Closed

Qiskit wrapper #3

wants to merge 482 commits into from

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Sep 25, 2021 •
edited
Loading

This is the same modification as in #2, but with the commit history.
Blocker:
#1

Reference Issue:
pyRiemann/pyRiemann#141

alexandrebarachant and others added 30 commits July 25, 2016 20:08
@alexandrebarachant
spatial filtering coverage
896f48d
@alexandrebarachant
travis with conda
7f8ebbe
@alexandrebarachant
add env
9fccc5b
@alexandrebarachant
codecov with pip
a0e1ea9
@alexandrebarachant
update docstring
c5199d4
@alexandrebarachant
cast int
2e77a58
@emanuele
FIX: decommented imports in __init__.py to make README example work
b5749cd
Typo fixed in mean_covariance docstring
7023846
@alexandrebarachant
Merge pull request #36 from emanuele/patch-1
c16ab02 
Typo fixed in mean_covariance docstring
@emanuele
imported clustering in __init__.py
c795672
@alexandrebarachant
small change
94caef3
@alexandrebarachant
Merge branch 'master' of github.com:alexandrebarachant/pyRiemann
c7db381
@alexandrebarachant
refactoring statistic module
1994404
@alexandrebarachant
update examples and test
ab7bd05
@alexandrebarachant
remove init in BasePermutation
39d5cbd
@emanuele
FIX: relative imports in __init__.py to work on py3 + imported stats
713c6f0
@alexandrebarachant
Merge pull request #35 from emanuele/fix_init
13115a9 
FIX: decommented imports in __init__.py to make README example work
@alexandrebarachant
add shrinkage estimator
f927666
@alexandrebarachant
Jr Comments
4b5a449
@alexandrebarachant
Merge pull request #38 from alexandrebarachant/Shrinkage
f279c2b 
[MRG] Shrinkage Transformer
@alexandrebarachant
fix minor problem in examples
e94d67a
@alexandrebarachant
merge conflic
e284915
@alexandrebarachant
factorize code in base functions
6125e2a
@alexandrebarachant
fix coherence and add Coherences transformer
fb4b9af
@alexandrebarachant
add test for coherence
38c3ec1
@alexandrebarachant
Explicit error as a consequence of non spd matrices
e5a4cc6
@alexandrebarachant
add test
77d2f88
@alexandrebarachant
Merge pull request #41 from alexandrebarachant/SPD_check
159b754 
ENH: Explicit error as a consequence of non-spd matrices
Update README.md
882eee8
@alexandrebarachant
fix error in ajd for python 3
811a807
@gcattan
test workaround from code
30db8cb
@gcattan
clean example
bf6a097
@gcattan
re-use set workaround
b449484
@gcattan
typo
8ebf826
@gcattan
revert sed: will pop an error, but anyway it is not in the doc requir…
96bd7c9 
…ements...
@gcattan
flake8
bfb2eb9
@gcattan
- clean everything related to pyRiemann core implementation
679f99e 
- add quantum wrapper
- update dependency and setup file
@gcattan
separe quantum implementation from repo architecture
812be71
@gcattan
Quantum classification and example
688fd1e
@gcattan
remove tests
d4317c3
@gcattan
add test_classification.py
e5406ab
@gcattan
flake8
7575d5f
@gcattan
Merge branch 'gc/base' into gc/quantum
9e4305a
@gcattan
Revert "remove tests"
b82f7f2 
This reverts commit d4317c3.
@gcattan
Merge branch 'gc/base' of https://github.com/gcattan/pyRiemann-qiskit …
5009787 
…into gc/QSVM

# Conflicts:
#	.gitignore
#	README.md
#	doc/requirements.txt
#	requirements.txt
#	setup.py
@gcattan
- move classification.py to pyriemann-qiskit
dd7b05a
@gcattan
Merge branch 'gc/quantum' into gc/QSVM
f551ae2 
# Conflicts:
#	examples/ERP/plot_classify_EEG_quantum.py
#	pyriemann_qiskit/classification.py
#	tests/test_classification.py
@gcattan
delete examples already in pyRiemann
15e50bb
@gcattan
deleting tests
6415402
@gcattan gcattan mentioned this pull request Sep 25, 2021
Merged
@qbarthelemy
Copy link
Member

Since pyRiemann-qiskit uses pyRiemann as dependency, IMO, it is better to do not inherit the long commit history of pyRiemann.
So, I prefer #2. @gcattan, are you ok to close this PR?

@gcattan
Copy link
Collaborator Author

gcattan commented Sep 27, 2021

Sure, I understand :)

@gcattan gcattan closed this Sep 27, 2021
@gcattan gcattan deleted the gc/base-quantum branch November 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.