Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/get_weights method on optimizer #127

Merged
merged 13 commits into from
May 17, 2023
Merged

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented May 16, 2023

This PR adds a get_weights method to optimizers, which returns an array of docplex decision variables.
This PR also introduced the reshape parameter in the private method _solve_qp and public method solve.

In addition, it fixes also the docker dependency issue with the protobuf version.

gcattan added 13 commits May 16, 2023 20:43
Add get_weights method to optimizers
missing versionchanged
Fix protobuf version in dockerfile
fix google_cloud_firestore-2.11.0
missing -py3.8
remove py3.8
try anothe protobuf dependency
re-introduced -py3.8 for google_cloud_firestore
@gcattan gcattan marked this pull request as ready for review May 17, 2023 10:34
Copy link
Collaborator

@toncho11 toncho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added get_weights in the base class and you implemented it in the two classes that inherit it.
You updated some versions.
You updated _solve_qp method as well.

@gcattan gcattan merged commit e1ef2a8 into pyRiemann:main May 17, 2023
@gcattan
Copy link
Collaborator Author

gcattan commented May 17, 2023

Thanks @toncho11 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants