Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantic mdm #130

Merged
merged 43 commits into from
May 27, 2023
Merged

Quantic mdm #130

merged 43 commits into from
May 27, 2023

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented May 26, 2023

This PR is part of #27.
It overrides MDM._predict_distances to be compatible with our convex distance.
It also provides a wrapper around MDM which inherits from QuanticClassifierBase.
This allows running the optimization on a quantum backend if the convex metric is selected and quantum=True.
@toncho FYI

gcattan and others added 30 commits April 20, 2023 11:42
@gcattan
Update classification.py
f2bd941
@gcattan
add template for QMDM
a4a856b
@gcattan
add test template
d0fff94
@gcattan
add mdm docplex model
c37d07c
@gcattan
flake8
f26a902
@gcattan
add docplex mdm test
169cdd8
@gcattan
flake8
9cae55f
@gcattan
list to numpy array conversion
db10cc4
@gcattan
use matrices no vectors for MDM
f7f9e7c
@gcattan
get binary square matrices
4605fcd
@gcattan
flake8
0285db8
@gcattan
use ndarray
58358f5
@gcattan
use covariance matrices for MDM
42a2aa0
@gcattan
fix fixture being called from conftest
82de818
fix docplex test?
6ed3cd2
running mdm
1f3c6dc
passing docplex test
1a6ce99
flake8
559d3ad
test_classification pass
5f90bec
cvx method used inside QuanticMDM. May be distance function is wrong …
a68e5c9 
…inside cvx method?
logeuclid distance
1b85cdf
create distance package
1540553
override _predict_distances
57618d8
create test_utils_distance
82650a2
fix a couple of bugs with tests
623d5b5
docplex doc
6b6c82f
flake8 docplex
d10f79c
@gcattan
Merge branch 'pyRiemann:main' into quantic-mdm
f612bb4
@gcattan
Merge branch 'main' into quantic-mdm
8a178ea
@gcattan
correct some typos. Reintroduce TestQuantumClassifierWithDefaultRiema…
28fd6eb 
…nnianPipeline
@gcattan gcattan requested a review from toncho11 May 26, 2023 20:25
toncho11
toncho11 approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@toncho11 toncho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@gcattan gcattan merged commit 05f4043 into pyRiemann:main May 27, 2023
@gcattan
Copy link
Collaborator Author

gcattan commented May 27, 2023

Thanks! Good luck with the example :)

@gcattan gcattan mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toncho11 toncho11 toncho11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcattan @toncho11