Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiclass classification #178

Merged
merged 54 commits into from
Sep 5, 2023
Merged

Multiclass classification #178

merged 54 commits into from
Sep 5, 2023

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Aug 26, 2023

This PR enables multiclass classification, as per #6.
The Qiskit API has considerably changed since issue #6 was opened, so the implementation was quicker than expected.

gcattan and others added 30 commits August 25, 2023 17:54
add multilabel test for quantum vqc
change get_binary_feat to get_separable_feat
replace base by super
renamed:
- _map_0_1_to_classes
- _map_1_0_to_classes

remove exception for binary classification in :
- _split_classes and fit
change class to idx and split methods to support multi labels classification
add test for split classes with n_classes = 3
fix test on split_classes
fix bug with split_classes (index error)
remove hardcoded n_classes=2
fix the number of sample
fix class_len not updated after updating number of classes from 2 to 3
general one-hot encoded for multi-class
Copy link
Collaborator

@toncho11 toncho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@toncho11 toncho11 merged commit 0d98b92 into pyRiemann:main Sep 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants