Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyRiemann-qiskit v0.1.0 #189

Merged
merged 15 commits into from
Oct 4, 2023
Merged

pyRiemann-qiskit v0.1.0 #189

merged 15 commits into from
Oct 4, 2023

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Oct 3, 2023

@sylvchev @qbarthelemy @toncho11

I think we have enough material to deliver v0.1.0. We made good progress with the quantum MDM, enabled multiclass classification, and included more examples.

We have a few ideas for v0.1.1 that we can discuss :

  1. Neural network and quantum
  2. Quantum emulation with copy classifier
  3. Evaluation on real quantum backends (we have some credits to use thanks to the IBM quantum research program)
  4. Quantum art and visualization
  5. Comparison of quantum vs classical computers for bci illiteracy
  6. ...

Let me know what you think.

@gcattan gcattan marked this pull request as ready for review October 3, 2023 19:09
@qbarthelemy qbarthelemy changed the title pyRiemann v0.1.0 pyRiemann-qiskit v0.1.0 Oct 3, 2023
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for me to release v0.1.0.

In the gallery, we could create a new item "Classification on other datasets", grouping the examples on Titanic dataset, multiclass EEG and dimension reduction. These three examples are neither ERP nor toy datasets classification examples.

@gcattan, keep the good practice of creating the branch in your personal fork, and not from the upstream repository.

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 4, 2023

Yes, sorry about that, I will pay attention for the next PRs.
Thank you for the review!

@gcattan gcattan merged commit 7da6d56 into main Oct 4, 2023
10 checks passed
@toncho11
Copy link
Collaborator

toncho11 commented Oct 4, 2023

I wanted to add that I am against these 0.X.X versioning in general. Why never using the first digit?
I think it should be 1.0 and we continue with 1.1, 1.2 etc.
Also @gcattan you can add a release on github if this is pertinent.

@gcattan
Copy link
Collaborator Author

gcattan commented Oct 4, 2023

@toncho11 I try to follow semantic versioning. In X.Y.Z, X is for major, Y for minor, and Z for patches.
X being 0, just means that the public API is not yet stable.
But you are not wrong. Maybe it is stable enough to release 1.0.0 next time.

Yes, I plan to release on github and pypi, but I would like to merge #191 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants