Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow cov_to_corr_matrix to process multiple matrices at once #191

Merged
merged 5 commits into from
Oct 4, 2023
Merged

allow cov_to_corr_matrix to process multiple matrices at once #191

merged 5 commits into from
Oct 4, 2023

Conversation

qbarthelemy
Copy link
Member

No description provided.

@qbarthelemy
Copy link
Member Author

It would also be possible to depreciate cov_to_corr_matrix.

@gcattan
Copy link
Collaborator

gcattan commented Oct 4, 2023

Yes, it could be redundant with pyRiemann normalize function, but cov_to_corr_matrix is also more specific.
I leave it up to you :)

We will need the changes in the docker file for the ci/cd to pass:

image

@gcattan
Copy link
Collaborator

gcattan commented Oct 4, 2023

PR merged, thanks :) You can rebase your branch for the Docker CI to pass.

@gcattan gcattan mentioned this pull request Oct 4, 2023
Merged
@qbarthelemy
Copy link
Member Author

Branch is rebased, but docker CI failed.

@gcattan gcattan self-requested a review October 4, 2023 22:00
@gcattan gcattan merged commit 3141dd6 into pyRiemann:main Oct 4, 2023
@gcattan
Copy link
Collaborator

gcattan commented Oct 4, 2023

Thanks @qbarthelemy!

@qbarthelemy qbarthelemy deleted the utils_math branch October 4, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcattan gcattan gcattan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbarthelemy @gcattan